Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: record the single page query conditions in the route query parameters #4208

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 13, 2023

What type of PR is this?

/area console
/kind feature
/milestone 2.8.x

What this PR does / why we need it:

在页面数据管理列表页面路由中记录查询条件,包括分页信息、筛选信息等。可以保证在刷新浏览器窗口或者从编辑页面返回时保留之前的查询状态。

image

Special notes for your reviewer:

需要测试:

  1. 页面管理列表的所有筛选项是否可以正常工作。
  2. 尝试设置部分筛选,然后刷新页面,观察筛选条件是否正常保留。
  3. 尝试设置部分筛选,然后选择任意一个页面进行编辑,观察发布之后是否正常返回到管理列表,并正确设置了查询参数。

Does this PR introduce a user-facing change?

Console 端的页面管理列表支持在地址栏记录筛选条件。

…meters

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added this to the 2.8.x milestone Jul 13, 2023
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 13, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and LIlGG July 13, 2023 05:10
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #4208 (ef865b4) into main (1dc2f6f) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4208      +/-   ##
============================================
- Coverage     60.18%   60.04%   -0.15%     
+ Complexity     2414     2409       -5     
============================================
  Files           366      366              
  Lines         12586    12586              
  Branches        906      906              
============================================
- Hits           7575     7557      -18     
- Misses         4571     4590      +19     
+ Partials        440      439       -1     

see 5 files with indirect coverage changes

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

刷新页面后部分筛选条件未正确渲染。

  • 刷新前

    image
  • 刷新后

    image

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@ruibaby
Copy link
Member Author

ruibaby commented Jul 19, 2023

刷新页面后部分筛选条件未正确渲染。

Fixed

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

image

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 2ade571 into halo-dev:main Jul 19, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.8.x, 2.8.0 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants