Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize the usage of comment widget extension point #4249

Merged
merged 1 commit into from Jul 20, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Jul 18, 2023

What type of PR is this?

/kind improvement
/area core
/milestone 2.8.x

What this PR does / why we need it:

优化评论扩展点的使用方式

how to test it?
测试评论插件是否正常可用

Does this PR introduce a user-facing change?

优化评论扩展点的使用方式

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 18, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.8.x milestone Jul 18, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #4249 (ad469fe) into main (5a0e202) will increase coverage by 0.00%.
The diff coverage is 90.00%.

@@            Coverage Diff            @@
##               main    #4249   +/-   ##
=========================================
  Coverage     60.14%   60.14%           
- Complexity     2413     2415    +2     
=========================================
  Files           366      366           
  Lines         12587    12593    +6     
  Branches        906      907    +1     
=========================================
+ Hits           7570     7574    +4     
- Misses         4578     4579    +1     
- Partials        439      440    +1     
Impacted Files Coverage Δ
.../plugin/extensionpoint/DefaultExtensionGetter.java 60.00% <84.61%> (-0.98%) ⬇️
.../app/theme/dialect/CommentElementTagProcessor.java 100.00% <100.00%> (ø)

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JohnNiang JohnNiang added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 20, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 133e541 into halo-dev:main Jul 20, 2023
4 checks passed
@guqing guqing deleted the refactor/comment-ext branch July 20, 2023 09:00
@ruibaby ruibaby modified the milestones: 2.8.x, 2.8.0 Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants