feat: add attachment policy and group selection component to formkit #4258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note-none
f2c-ci-robot
bot
added
the
area/console
…mkit-attachment-select
ruibaby
changed the title
ruibaby
changed the title
LIlGG
changed the title
Codecov Report
@@ Coverage Diff @@
## main #4258 +/- ##
=========================================
Coverage 60.04% 60.04%
Complexity 2409 2409
=========================================
Files 366 366
Lines 12586 12586
Branches 906 906
=========================================
Hits 7557 7557
Misses 4590 4590
Partials 439 439 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
f2c-ci-robot
bot
added
release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/area console
What this PR does / why we need it:
为 formkit 添加一个
attachmentPolicySelect类型的下拉选择框组件，用来供用户选择附件策略。同时也添加了一个
attachmentGroupSelect类型的下拉选择框组件，用来供用户选择附件分组。Which issue(s) this PR fixes:
Fixes #4247
Special notes for your reviewer:
使用 formkit 组件时将 type 修改为
attachmentPolicySelect或attachmentGroupSelect，查看是否能够展示一个可以选择附件策略或附件分组的组件，Does this PR introduce a user-facing change?