New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support extending username password authentication #4265
Support extending username password authentication #4265
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4265 +/- ##
============================================
+ Coverage 60.16% 60.28% +0.11%
- Complexity 2418 2426 +8
============================================
Files 366 367 +1
Lines 12617 12637 +20
Branches 906 906
============================================
+ Hits 7591 7618 +27
+ Misses 4585 4577 -8
- Partials 441 442 +1
|
@JohnNiang: GitHub didn't allow me to request PR reviews from the following users: liuchangfitcloud. Note that only halo-dev members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
需要合并一下冲突 |
…-manager-ext-point
.../halo/app/security/authentication/login/UsernamePasswordDelegatingAuthenticationManager.java
Outdated
Show resolved
Hide resolved
.../halo/app/security/authentication/login/UsernamePasswordDelegatingAuthenticationManager.java
Outdated
Show resolved
Hide resolved
@JohnNiang extensionpoint-definitions.yaml type:SINGLE_INSTANCE Not Found |
感谢提醒!已经在 eb28a02 修复。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area core
/area plugin
What this PR does / why we need it:
Plugin developers are able to define own UsernamePasswordAuthenticationManager to take charge of username password authentication.
Mono.empty()
, the default authentication manager will be used.For example:
Which issue(s) this PR fixes:
See #4207 (comment) for more.
Does this PR introduce a user-facing change?