New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sort parameter when listing extensions #4274
Support sort parameter when listing extensions #4274
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4274 +/- ##
============================================
- Coverage 60.30% 60.13% -0.17%
+ Complexity 2423 2407 -16
============================================
Files 366 364 -2
Lines 12617 12584 -33
Branches 906 903 -3
============================================
- Hits 7609 7568 -41
- Misses 4566 4575 +9
+ Partials 442 441 -1
|
application/src/main/java/run/halo/app/extension/router/ExtensionRouterFunctionFactory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold |
Signed-off-by: Ryan Wang <i@ryanc.cc>
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area core
What this PR does / why we need it:
Currently, we cannot pass a sort parameter into extensions' list API, so the result of the API is unsortable.
This PR add the support for that API. e.g.:
Does this PR introduce a user-facing change?