chore: bump default editor version to 27 #4288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Wang <i@ryanc.cc>
f2c-ci-robot
bot
added
area/console
f2c-ci-robot
bot
added
area/editor
Codecov Report
@@ Coverage Diff @@
## main #4288 +/- ##
=========================================
Coverage 60.62% 60.62%
Complexity 2498 2498
=========================================
Files 370 370
Lines 13047 13047
Branches 935 935
=========================================
Hits 7910 7910
Misses 4678 4678
Partials 459 459 |
JohnNiang
reviewed
Jul 24, 2023
There was a problem hiding this comment.
需要解决一下 CI 错误：
> @halo-dev/console@2.7.0 typecheck /home/runner/work/halo/halo/console
> vue-tsc --noEmit -p tsconfig.app.json --composite false && pnpm run typecheck:packages
Error: src/components/editor/DefaultEditor.vue(470,5): error TS2322: Type 'string' is not assignable to type '"en" | "en-US" | "zh-CN" | "zh" | undefined'.
ELIFECYCLE Command failed with exit code 2.
make: *** [Makefile:14: lint] Error 1
make: Leaving directory '/home/runner/work/halo/halo/console'
Error: Process completed with exit code 2.See https://github.com/halo-dev/halo/actions/runs/5642892304/job/15283662005?pr=4288 for more.
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
|
/hold 此版本的内容区域无法滚动。 |
f2c-ci-robot
bot
added
the
do-not-merge/hold
Signed-off-by: Ryan Wang <i@ryanc.cc>
ruibaby
removed
the
do-not-merge/hold
|
@halo-dev/sig-halo-console |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
|
/lgtm |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area console
/area editor
/milestone 2.8.x
/kind feature
What this PR does / why we need it:
升级默认编辑器以支持：
Does this PR introduce a user-facing change?