refactor: refactor pagination component to support display total items #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Wang <i@ryanc.cc>
f2c-ci-robot
bot
added
release-note
f2c-ci-robot
bot
added
the
kind/improvement
Codecov Report
@@ Coverage Diff @@
## main #4303 +/- ##
============================================
- Coverage 60.76% 60.62% -0.14%
+ Complexity 2503 2498 -5
============================================
Files 370 370
Lines 13047 13047
Branches 935 935
============================================
- Hits 7928 7910 -18
- Misses 4659 4678 +19
+ Partials 460 459 -1 |
f2c-ci-robot
bot
added
the
approved
wzrove
approved these changes
Jul 27, 2023
JohnNiang
reviewed
Jul 28, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang, wzrove The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area console
/kind improvement
/milestone 2.8.x
What this PR does / why we need it:
重构 Console 的分页组件，以支持显示数据总条数。
Which issue(s) this PR fixes:
Fixes #4268
Special notes for your reviewer:
需要测试：
Does this PR introduce a user-facing change?