Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve the system initialization process #4306

Merged
merged 21 commits into from Aug 11, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Jul 26, 2023

What type of PR is this?

/kind improvement
/area core
/area console
/milestone 2.9.x

What this PR does / why we need it:

改进系统初始化流程

Which issue(s) this PR fixes:

Fixes #3230

Does this PR introduce a user-facing change?

改进系统初始化流程,支持在初始化页面创建管理员。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Jul 26, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.9.x milestone Jul 26, 2023
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core area/console Issues or PRs related to the Halo Console labels Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #4306 (4a9d321) into main (1172f4a) will decrease coverage by 0.12%.
The diff coverage is 39.10%.

@@             Coverage Diff              @@
##               main    #4306      +/-   ##
============================================
- Coverage     60.99%   60.88%   -0.12%     
- Complexity     2497     2509      +12     
============================================
  Files           367      370       +3     
  Lines         12922    12989      +67     
  Branches        925      927       +2     
============================================
+ Hits           7882     7908      +26     
- Misses         4585     4627      +42     
+ Partials        455      454       -1     
Files Changed Coverage Δ
...java/run/halo/app/actuator/GlobalInfoEndpoint.java 1.35% <0.00%> (-0.12%) ⬇️
...a/run/halo/app/config/WebServerSecurityConfig.java 95.34% <ø> (+4.23%) ⬆️
.../run/halo/app/infra/properties/HaloProperties.java 86.95% <ø> (-0.55%) ⬇️
.../halo/app/infra/properties/SecurityProperties.java 62.50% <ø> (+6.94%) ⬆️
...a/run/halo/app/security/SuperAdminInitializer.java 0.00% <0.00%> (ø)
...alo/app/security/DefaultSuperAdminInitializer.java 5.00% <5.00%> (ø)
...tension/endpoint/SystemInitializationEndpoint.java 31.48% <31.48%> (ø)
...lo/app/infra/DefaultInitializationStateGetter.java 71.42% <71.42%> (ø)
.../src/main/java/run/halo/app/infra/SystemState.java 86.36% <86.36%> (ø)
...o/app/security/InitializeRedirectionWebFilter.java 100.00% <100.00%> (+7.69%) ⬆️

... and 5 files with indirect coverage changes

@guqing
Copy link
Member Author

guqing commented Jul 27, 2023

/hold wait for console adaptation

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2023
@ruibaby
Copy link
Member

ruibaby commented Aug 6, 2023

image image

初始化接口调用之后,/actuator/globalinfo 接口的 initialized 字段没有更新,并且可以继续调用初始化的接口。重启之后也没有更新状态。

@guqing
Copy link
Member Author

guqing commented Aug 8, 2023

image image
初始化接口调用之后,/actuator/globalinfo 接口的 initialized 字段没有更新,并且可以继续调用初始化的接口。重启之后也没有更新状态。

Done

ruibaby and others added 6 commits August 8, 2023 14:58
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Copy link
Member

ruibaby commented Aug 9, 2023

/unhold

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@JohnNiang JohnNiang merged commit 5690de3 into halo-dev:main Aug 11, 2023
3 of 4 checks passed
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2023
@JohnNiang JohnNiang modified the milestones: 2.9.x, 2.9.0 Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

完善初始化流程
4 participants