Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user detail page switching does not take effect #4321

Merged
merged 1 commit into from Jul 28, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 28, 2023

What type of PR is this?

/area console
/kind bug
/milestone 2.8.x

What this PR does / why we need it:

修复用户详情页面切换用户之后,数据不更新的问题。操作路径:

  1. 进入任意一个用户的资料页面。
  2. 点击左下角当前登录用户的个人资料。

Which issue(s) this PR fixes:

Fixes #4320

Special notes for your reviewer:

Does this PR introduce a user-facing change?

修复用户详情页面切换用户之后,数据不更新的问题。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 28, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.8.x milestone Jul 28, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 28, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from wan92hen and wzrove July 28, 2023 02:44
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #4321 (72310a4) into main (4f1537b) will increase coverage by 0.39%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4321      +/-   ##
============================================
+ Coverage     60.61%   61.00%   +0.39%     
+ Complexity     2498     2490       -8     
============================================
  Files           370      368       -2     
  Lines         13048    12905     -143     
  Branches        936      921      -15     
============================================
- Hits           7909     7873      -36     
+ Misses         4679     4578     -101     
+ Partials        460      454       -6     

see 27 files with indirect coverage changes

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit e0d79cc into halo-dev:main Jul 28, 2023
4 checks passed
@JohnNiang JohnNiang modified the milestones: 2.8.x, 2.8.0 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

用户资料详情页切换时页面不更新
3 participants