Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page does not refresh or get wrong page when turn page #4331

Merged
merged 3 commits into from Jul 31, 2023

Conversation

Erzbir
Copy link
Contributor

@Erzbir Erzbir commented Jul 29, 2023

What type of PR is this?

/kind bug
/area console

What this PR does / why we need it:

在预览附件时点击 "下一个" 或者 "上一个", 如果这时翻页, 预览页面可能不会刷新, 也可能刷新到其他非预料中的页面

Which issue(s) this PR fixes:

Fixes #4330

Special notes for your reviewer:

  1. 准备附件测试翻页
  2. 在第一页的最后一个附件预览中点击 "next", 观察是否正常
  3. 在第二页的第一个附件预览中点击 "pre", 观察是否正常

Does this PR introduce a user-facing change?

预览附件点击 "下一个" 或者 "上一个" 翻页后, 预览页面不正常刷新

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Jul 29, 2023
@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #4331 (3564f37) into main (8e0538e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4331   +/-   ##
=========================================
  Coverage     60.97%   60.97%           
  Complexity     2492     2492           
=========================================
  Files           368      368           
  Lines         12911    12911           
  Branches        924      924           
=========================================
  Hits           7873     7873           
  Misses         4585     4585           
  Partials        453      453           

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Nice Work!

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

Thanks for your contribution!

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 897b603 into halo-dev:main Jul 31, 2023
4 checks passed
@Erzbir Erzbir deleted the fix-attachment-turnPage branch July 31, 2023 08:21
@Erzbir Erzbir restored the fix-attachment-turnPage branch July 31, 2023 08:21
@Erzbir Erzbir deleted the fix-attachment-turnPage branch July 31, 2023 08:22
@ruibaby ruibaby added this to the 2.8.0 milestone Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

预览附件时点击 "pre" 或 "next" 翻页后页面不刷新或者页面刷新错误
4 participants