Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not reset permission after cloning a role #4333

Merged
merged 1 commit into from Aug 1, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 30, 2023

What type of PR is this?

/area console
/kind bug
/milestone 2.8.x

What this PR does / why we need it:

修复创建角色时,如果基于某个角色创建,实际权限可能不会更新的问题。

Special notes for your reviewer:

需要测试:

  1. 基于超级管理员创建新角色。
  2. 取消勾选一些角色模板。
  3. 测试此角色是否存在取消了勾选的角色模板。

Does this PR introduce a user-facing change?

修复创建角色时,如果基于某个角色创建,实际权限可能不会更新的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Jul 30, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.8.x milestone Jul 30, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 30, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and wan92hen July 30, 2023 13:33
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #4333 (e0e4184) into main (8e0538e) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4333   +/-   ##
=========================================
  Coverage     60.97%   60.97%           
  Complexity     2492     2492           
=========================================
  Files           368      368           
  Lines         12911    12911           
  Branches        924      924           
=========================================
  Hits           7873     7873           
  Misses         4585     4585           
  Partials        453      453           

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
work fine🎉

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JohnNiang JohnNiang added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 370b44f into halo-dev:main Aug 1, 2023
4 checks passed
@ruibaby ruibaby deleted the fix/role-clone branch August 1, 2023 02:56
@ruibaby ruibaby modified the milestones: 2.8.x, 2.8.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants