Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update zh-tw translation for refresh search engine operation #4335

Merged
merged 1 commit into from Aug 1, 2023

Conversation

cetr
Copy link
Member

@cetr cetr commented Jul 30, 2023

What type of PR is this?

/kind improvement
/area console
/milestone 2.8.x

What this PR does / why we need it:

优化刷新搜索引擎索引的文案。

Does this PR introduce a user-facing change?

优化刷新搜索引擎索引的文案。

描述有歧义,不好理解,补充完整意思
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 30, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG July 30, 2023 14:37
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #4335 (90128cb) into main (8e0538e) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4335   +/-   ##
=========================================
  Coverage     60.97%   60.97%           
  Complexity     2492     2492           
=========================================
  Files           368      368           
  Lines         12911    12911           
  Branches        924      924           
=========================================
  Hits           7873     7873           
  Misses         4585     4585           
  Partials        453      453           

@ruibaby ruibaby changed the title 描述有歧义,不好理解,补充完整意思 chore: update zh-tw translation for refresh search engine operation Jul 31, 2023
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 31, 2023
@ruibaby ruibaby added area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. labels Jul 31, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 81e985f into halo-dev:main Aug 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants