Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support restarting Halo #4361

Merged
merged 5 commits into from Aug 9, 2023
Merged

Support restarting Halo #4361

merged 5 commits into from Aug 9, 2023

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Aug 2, 2023

What type of PR is this?

/kind feature
/area core
/milestone 2.9.x

What this PR does / why we need it:

Support restarting Halo and enable restart endpoint by default.

Restart endpoint detail:

request uri: /actuator/restart
request method: POST

Please note that memory usage may slightly increase after restarting Halo.

Does this PR introduce a user-facing change?

系统恢复完成之后支持自动重启 Halo 。

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 2, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.9.x milestone Aug 2, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Aug 2, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and ruibaby August 2, 2023 09:38
Signed-off-by: Ryan Wang <i@ryanc.cc>
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #4361 (cb70f6b) into main (9774530) will decrease coverage by 0.11%.
Report is 3 commits behind head on main.
The diff coverage is 18.18%.

@@             Coverage Diff              @@
##               main    #4361      +/-   ##
============================================
- Coverage     60.97%   60.86%   -0.11%     
- Complexity     2492     2495       +3     
============================================
  Files           368      369       +1     
  Lines         12911    12944      +33     
  Branches        924      927       +3     
============================================
+ Hits           7873     7879       +6     
- Misses         4585     4611      +26     
- Partials        453      454       +1     
Files Changed Coverage Δ
...in/java/run/halo/app/actuator/RestartEndpoint.java 18.18% <18.18%> (ø)

@JohnNiang
Copy link
Member Author

Hi @ruibaby ,可能需要同步修改一下恢复页面和确认框的文案。

@cartebrother cartebrother mentioned this pull request Aug 2, 2023
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Copy link
Member

ruibaby commented Aug 7, 2023

Hi @ruibaby ,可能需要同步修改一下恢复页面和确认框的文案。

Done

@ruibaby
Copy link
Member

ruibaby commented Aug 7, 2023

@halo-dev/sig-halo 建议好好测一下这个 PR。

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@LIlGG
Copy link
Member

LIlGG commented Aug 9, 2023

/lgtm

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 1172f4a into halo-dev:main Aug 9, 2023
4 checks passed
@JohnNiang JohnNiang deleted the feat/restart branch August 9, 2023 14:54
@JohnNiang JohnNiang modified the milestones: 2.9.x, 2.9.0 Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants