Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve the issue of ineffective duplicate key validation in AnnotationsForm #4369

Merged
merged 2 commits into from Aug 8, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 3, 2023

What type of PR is this?

/kind bug
/area console

What this PR does / why we need it:

在 AnnotationsForm 新增 customAnnotationsDuplicateKey 校验规则,校验自定义元数据中是否具有重复的 key。

Which issue(s) this PR fixes:

Fixes #4367

Special notes for your reviewer:

在任意一个使用 AnnotationsForm 的位置,例如文章设置 - 元数据 中,新增一个已经存在的 key,查看是否有重复 key 的校验。

Does this PR introduce a user-facing change?

修复 AnnotationsForm 重复的 key 校验无效的问题。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #4369 (96ab62e) into main (6b748ef) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4369   +/-   ##
=========================================
  Coverage     60.97%   60.97%           
  Complexity     2492     2492           
=========================================
  Files           368      368           
  Lines         12911    12911           
  Branches        924      924           
=========================================
  Hits           7873     7873           
  Misses         4585     4585           
  Partials        453      453           

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
It works very well🎉

image

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 3ec4091 into halo-dev:main Aug 8, 2023
4 checks passed
@ruibaby ruibaby added this to the 2.9.0 milestone Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnnotationsForm 重复的 Key 校验无效
3 participants