Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support displaying private posts for owner on theme-side #4412

Merged
merged 4 commits into from Aug 25, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Aug 11, 2023

What type of PR is this?

/kind feature
/area core
/milestone 2.9.x

What this PR does / why we need it:

登录后支持在主题端展示作者的私有文章

how to test it?

  1. 测试登录后是否能访问到自己创建的私有文章,退出登录后私有文章消失
  2. 不能在在主题端看到别人创建的私有文章
  3. 创建私有文章测试登录后使用主题端的上一页下一页功能是否正常

Which issue(s) this PR fixes:

Fixes #3016

Does this PR introduce a user-facing change?

登录后支持在主题端展示作者的私有文章

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 11, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.9.x milestone Aug 11, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG August 11, 2023 09:52
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Aug 11, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from ruibaby August 11, 2023 09:52
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #4412 (8c5d2fa) into main (b437756) will increase coverage by 0.00%.
The diff coverage is 51.35%.

@@            Coverage Diff            @@
##               main    #4412   +/-   ##
=========================================
  Coverage     61.12%   61.13%           
- Complexity     2521     2532   +11     
=========================================
  Files           372      372           
  Lines         12919    12936   +17     
  Branches        928      927    -1     
=========================================
+ Hits           7897     7908   +11     
- Misses         4573     4577    +4     
- Partials        449      451    +2     
Files Changed Coverage Δ
...un/halo/app/theme/finders/impl/PostFinderImpl.java 62.68% <20.00%> (-1.16%) ⬇️
...theme/finders/impl/PostPublicQueryServiceImpl.java 30.23% <33.33%> (ø)
...o/app/theme/router/factories/PostRouteFactory.java 52.68% <42.85%> (-0.06%) ⬇️
...heme/router/DefaultQueryPostPredicateResolver.java 85.71% <85.71%> (ø)

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

实际表现符合预期。

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 637071b into halo-dev:main Aug 25, 2023
4 checks passed
@guqing guqing deleted the feature/3016 branch August 25, 2023 15:18
@ruibaby ruibaby modified the milestones: 2.9.x, 2.9.0 Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

私有文章无法在该作者的前端展示
3 participants