Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: allow annotations value to be empty #4419

Merged
merged 1 commit into from Aug 14, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 14, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

由于后端 annotation 的值可以为空,而前端则规定 annotation 值为必填项,因此去除前端必填属性。

Which issue(s) this PR fixes:

Fixes #4279

Does this PR introduce a user-facing change?

将元数据表单的值更改为非必填

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Aug 14, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from wan92hen and wzrove August 14, 2023 03:41
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #4419 (42d53c8) into main (905e867) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4419   +/-   ##
=========================================
  Coverage     60.99%   60.99%           
  Complexity     2507     2507           
=========================================
  Files           370      370           
  Lines         12910    12910           
  Branches        928      928           
=========================================
  Hits           7874     7874           
  Misses         4581     4581           
  Partials        455      455           

@LIlGG LIlGG added this to the 2.9.x milestone Aug 14, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@ruibaby ruibaby changed the title pref: allow metadata values to be empty pref: allow annotations value to be empty Aug 14, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 5779f01 into halo-dev:main Aug 14, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.9.x, 2.9.0 Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(偶现)某些情况下编辑文章时修改弹窗的保存按钮无效
3 participants