New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support getting backup root path in plugin #4422
Support getting backup root path in plugin #4422
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4422 +/- ##
============================================
+ Coverage 60.99% 61.01% +0.02%
- Complexity 2507 2509 +2
============================================
Files 370 371 +1
Lines 12910 12917 +7
Branches 928 928
============================================
+ Hits 7874 7881 +7
Misses 4581 4581
Partials 455 455
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area core
/milestone 2.9.x
What this PR does / why we need it:
We already support backup and restore feature in Halo 2.8.0, but we cannot obtain backup files through regular channels in the plugin. For example, we want to upload backup files to OSS in the plugin.
This PR is aimed at solving this problem.
Does this PR introduce a user-facing change?