Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support getting backup root path in plugin #4422

Merged

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind feature
/area core
/milestone 2.9.x

What this PR does / why we need it:

We already support backup and restore feature in Halo 2.8.0, but we cannot obtain backup files through regular channels in the plugin. For example, we want to upload backup files to OSS in the plugin.

This PR is aimed at solving this problem.

Does this PR introduce a user-facing change?

支持在插件中获取备份文件根目录。

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 14, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.9.x milestone Aug 14, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #4422 (558d0ac) into main (905e867) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #4422      +/-   ##
============================================
+ Coverage     60.99%   61.01%   +0.02%     
- Complexity     2507     2509       +2     
============================================
  Files           370      371       +1     
  Lines         12910    12917       +7     
  Branches        928      928              
============================================
+ Hits           7874     7881       +7     
  Misses         4581     4581              
  Partials        455      455              
Files Changed Coverage Δ
...va/run/halo/app/infra/DefaultBackupRootGetter.java 100.00% <100.00%> (ø)
.../halo/app/migration/impl/MigrationServiceImpl.java 84.55% <100.00%> (+0.12%) ⬆️
...alo/app/plugin/SharedApplicationContextHolder.java 96.55% <100.00%> (+0.25%) ⬆️

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 8e3bd7f into halo-dev:main Aug 14, 2023
4 checks passed
@JohnNiang JohnNiang deleted the feat/support-obtain-backup-root branch August 15, 2023 03:01
@ruibaby ruibaby modified the milestones: 2.9.x, 2.9.0 Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants