New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: redirection fails after login #4423
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4423 +/- ##
=========================================
Coverage 60.99% 60.99%
Complexity 2507 2507
=========================================
Files 370 370
Lines 12910 12910
Branches 928 928
=========================================
Hits 7874 7874
Misses 4581 4581
Partials 455 455 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么开发环境和生产环境的表现会有差异?
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
经过测试,本地使用与生产环境同样使用 docker 部署并且是相同的配置情况下,本地不会出现错误。另外,生产环境使用 IP + 端口的形式也不会出现错误。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/kind bug
What this PR does / why we need it:
对 console 跳转链接进行编码,用于解决跳转链接中如果携带非标准字符而导致的报错
How to test it?
本地开发环境:重定向地址无误且进行了 uri 编码即可。
生产环境:
在 console 后端未登录时,前往应用市场输入网站地址进行安装,之后进行登录,查看是否能够正确跳转。
Which issue(s) this PR fixes:
Fixes #4351
Does this PR introduce a user-facing change?