Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirection fails after login #4423

Merged
merged 1 commit into from Aug 15, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 14, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

对 console 跳转链接进行编码,用于解决跳转链接中如果携带非标准字符而导致的报错

How to test it?

本地开发环境:重定向地址无误且进行了 uri 编码即可。

生产环境:
在 console 后端未登录时,前往应用市场输入网站地址进行安装,之后进行登录,查看是否能够正确跳转。

Which issue(s) this PR fixes:

Fixes #4351

Does this PR introduce a user-facing change?

对 Console 重定向链接进行编码

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #4423 (cf98656) into main (905e867) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4423   +/-   ##
=========================================
  Coverage     60.99%   60.99%           
  Complexity     2507     2507           
=========================================
  Files           370      370           
  Lines         12910    12910           
  Branches        928      928           
=========================================
  Hits           7874     7874           
  Misses         4581     4581           
  Partials        455      455           

@LIlGG LIlGG added this to the 2.9.x milestone Aug 14, 2023
@ruibaby ruibaby changed the title fix: encode the redirect uri fix: redirection fails after login Aug 14, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么开发环境和生产环境的表现会有差异?

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@LIlGG
Copy link
Member Author

LIlGG commented Aug 15, 2023

为什么开发环境和生产环境的表现会有差异?

经过测试,本地使用与生产环境同样使用 docker 部署并且是相同的配置情况下,本地不会出现错误。另外,生产环境使用 IP + 端口的形式也不会出现错误。
因此此问题应该是由于多 ? 号参数导致用户侧反向代理拦截所导致的。

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 6282efb into halo-dev:main Aug 15, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.9.x, 2.9.0 Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

安装应用商城的应用报错
3 participants