Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reveal button for password input #4434

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 16, 2023

What type of PR is this?

/area console
/kind feature
/milestone 2.9.x

What this PR does / why we need it:

为 FormKit 的 password 类型输入框添加统一的显示/隐藏明文按钮。

image

Which issue(s) this PR fixes:

Fixes #4382

Special notes for your reviewer:

测试密码输入框的显示隐藏明文按钮是否可以正常使用即可。

Does this PR introduce a user-facing change?

为 FormKit 的 password 类型输入框添加统一的显示/隐藏明文按钮。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 16, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.9.x milestone Aug 16, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 16, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and guqing August 16, 2023 06:24
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #4434 (521c24d) into main (8678d61) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4434      +/-   ##
============================================
- Coverage     61.14%   61.05%   -0.10%     
+ Complexity     2519     2515       -4     
============================================
  Files           372      372              
  Lines         12926    12926              
  Branches        929      929              
============================================
- Hits           7904     7892      -12     
- Misses         4567     4579      +12     
  Partials        455      455              

see 4 files with indirect coverage changes

@LIlGG
Copy link
Member

LIlGG commented Aug 16, 2023

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 43e1e44 into halo-dev:main Aug 16, 2023
4 checks passed
@ruibaby ruibaby deleted the feat/add-reveal-button-for-password branch August 16, 2023 06:40
@ruibaby ruibaby modified the milestones: 2.9.x, 2.9.0 Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

希望在配置项表单中添加可显示明文的密码框
3 participants