Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: increasing the editor performance #4445

Merged
merged 1 commit into from Aug 20, 2023

Conversation

xinkeng0
Copy link
Contributor

A function to debounce editor updates was added to the DefaultEditor.vue component. This change was necessary to prevent excessive event executions. Now, 'update:raw', 'update:content', and 'update' events will be emitted 250ms after the last update, reducing the number of redundant operations and increasing the editor's performance.

What type of PR is this?

/kind improvement

What this PR does / why we need it:

目前默认编辑器在文章内容过多时,会出现输入延迟。

Which issue(s) this PR fixes:

Fixes #4389

Special notes for your reviewer:

Does this PR introduce a user-facing change?

增强默认编辑器在文章内容过大时的性能。

A function to debounce editor updates was added to the DefaultEditor.vue component. This change was necessary to prevent excessive event executions. Now, 'update:raw', 'update:content', and 'update' events will be emitted 250ms after the last update, reducing the number of redundant operations and increasing the editor's performance.
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Aug 19, 2023
@CLAassistant
Copy link

CLAassistant commented Aug 19, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #4445 (80da841) into main (43e1e44) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4445   +/-   ##
=========================================
  Coverage     61.05%   61.05%           
  Complexity     2515     2515           
=========================================
  Files           372      372           
  Lines         12926    12926           
  Branches        929      929           
=========================================
  Hits           7892     7892           
  Misses         4579     4579           
  Partials        455      455           

@ruibaby ruibaby changed the title perf: Increasing the editor performance #4389 perf: increasing the editor performance Aug 20, 2023
@ruibaby ruibaby added this to the 2.9.x milestone Aug 20, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2023
@JohnNiang JohnNiang added the area/console Issues or PRs related to the Halo Console label Aug 20, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 8ea397d into halo-dev:main Aug 20, 2023
4 checks passed
@JohnNiang JohnNiang modified the milestones: 2.9.x, 2.9.0 Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
4 participants