New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pref: user list supports searching by username #4451
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4451 +/- ##
============================================
- Coverage 61.19% 61.10% -0.10%
- Complexity 2520 2557 +37
============================================
Files 372 373 +1
Lines 12926 13104 +178
Branches 929 936 +7
============================================
+ Hits 7910 8007 +97
- Misses 4560 4642 +82
+ Partials 456 455 -1
|
Signed-off-by: guqing <i@guqing.email>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
application/src/main/java/run/halo/app/core/extension/endpoint/UserEndpoint.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议加上对应的单元测试。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area core
/milestone 2.9.x
What this PR does / why we need it:
用户列表搜索支持按用户名搜索
Which issue(s) this PR fixes:
Fixes #4256
Does this PR introduce a user-facing change?