Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: user list supports searching by username #4451

Merged
merged 6 commits into from Aug 25, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 21, 2023

What type of PR is this?

/kind improvement
/area core
/milestone 2.9.x

What this PR does / why we need it:

用户列表搜索支持按用户名搜索

Which issue(s) this PR fixes:

Fixes #4256

Does this PR introduce a user-facing change?

用户列表搜索支持按用户名搜索

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Aug 21, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.9.x milestone Aug 21, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #4451 (6e920dd) into main (8ea397d) will decrease coverage by 0.10%.
Report is 16 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #4451      +/-   ##
============================================
- Coverage     61.19%   61.10%   -0.10%     
- Complexity     2520     2557      +37     
============================================
  Files           372      373       +1     
  Lines         12926    13104     +178     
  Branches        929      936       +7     
============================================
+ Hits           7910     8007      +97     
- Misses         4560     4642      +82     
+ Partials        456      455       -1     
Files Changed Coverage Δ
...halo/app/core/extension/endpoint/UserEndpoint.java 88.33% <100.00%> (+1.35%) ⬆️

... and 22 files with indirect coverage changes

Signed-off-by: guqing <i@guqing.email>
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议加上对应的单元测试。

@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 1d9186c into halo-dev:main Aug 25, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.9.x, 2.9.0 Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

用户管理列表期望支持通过用户名搜索
4 participants