Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mouse scrolling handler for tabs component #4453

Merged
merged 1 commit into from Aug 25, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 21, 2023

What type of PR is this?

/area console
/kind feature
/milestone 2.9.x

What this PR does / why we need it:

Console 端的 Tabs 组件支持通过鼠标滚动选项卡。

2023-08-21 16 15 46

Which issue(s) this PR fixes:

Fixes #4353

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Console 端的 Tabs 组件支持通过鼠标滚动选项卡。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Aug 21, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.9.x milestone Aug 21, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wzrove August 21, 2023 08:16
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 21, 2023
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, wzrove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 141e22e into halo-dev:main Aug 25, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.9.x, 2.9.0 Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

希望后台主题的功能栏的选项卡超出显示范围后可以通过鼠标滚轮滚动
4 participants