Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish (ES) locale #4460

Merged
merged 3 commits into from Sep 1, 2023
Merged

Add Spanish (ES) locale #4460

merged 3 commits into from Sep 1, 2023

Conversation

yosoyjaff
Copy link
Contributor

@yosoyjaff yosoyjaff commented Aug 23, 2023

What type of PR is this?

/kind feature
/area core

What this PR does / why we need it:

feat: Add Spanish (ES) locale

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

新增西班牙語(ES)本地化

Signed-off-by: Josue Ferreira <josuealejandroferreira@gmail.com>
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 23, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4460 (0a59040) into main (e7f53fa) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4460   +/-   ##
=========================================
  Coverage     61.00%   61.00%           
  Complexity     2558     2558           
=========================================
  Files           373      373           
  Lines         13142    13142           
  Branches        937      937           
=========================================
  Hits           8017     8017           
  Misses         4670     4670           
  Partials        455      455           

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, here are some of the problems I found.

BTW, If you use vscode, this plugin may help you

image

console/src/locales/es.yaml Outdated Show resolved Hide resolved
console/src/locales/es.yaml Outdated Show resolved Hide resolved
console/src/locales/es.yaml Show resolved Hide resolved
console/src/locales/es.yaml Outdated Show resolved Hide resolved
@yosoyjaff yosoyjaff closed this Aug 29, 2023
@yosoyjaff yosoyjaff reopened this Aug 29, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
@ruibaby ruibaby merged commit 799a897 into halo-dev:main Sep 1, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants