New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spanish (ES) locale #4460
Add Spanish (ES) locale #4460
Conversation
Signed-off-by: Josue Ferreira <josuealejandroferreira@gmail.com>
|
Codecov Report
@@ Coverage Diff @@
## main #4460 +/- ##
=========================================
Coverage 61.00% 61.00%
Complexity 2558 2558
=========================================
Files 373 373
Lines 13142 13142
Branches 937 937
=========================================
Hits 8017 8017
Misses 4670 4670
Partials 455 455 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, here are some of the problems I found.
BTW, If you use vscode, this plugin may help you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area core
What this PR does / why we need it:
feat: Add Spanish (ES) locale
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?