Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store attachment view type to localStorage #4477

Merged
merged 2 commits into from Aug 24, 2023

Conversation

GodlessLiu
Copy link
Contributor

@GodlessLiu GodlessLiu commented Aug 24, 2023

What type of PR is this?

/kind improvement
/kind console

What this PR does / why we need it:

修改附件显示模式后,保存状态

Which issue(s) this PR fixes:

Fixes #4476

Does this PR introduce a user-facing change?

Console 端附件管理的显示模式支持缓存到浏览器。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Aug 24, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 24, 2023

@GodlessLiu: The label(s) kind/console cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind improvement
/kind console

What this PR does / why we need it:

修改附件显示模式后,保存状态

Which issue(s) this PR fixes:

Fixes #4476

Does this PR introduce a user-facing change?

修改附件显示模式后,保存状态

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #4477 (416e67d) into main (67a101e) will increase coverage by 0.13%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4477      +/-   ##
============================================
+ Coverage     61.11%   61.25%   +0.13%     
- Complexity     2523     2528       +5     
============================================
  Files           372      372              
  Lines         12942    12942              
  Branches        929      929              
============================================
+ Hits           7909     7927      +18     
+ Misses         4582     4563      -19     
- Partials        451      452       +1     

see 5 files with indirect coverage changes

@ruibaby ruibaby changed the title change attachmentList's viewType durable feat: store attachment view type to localStorage Aug 24, 2023
@ruibaby ruibaby added the area/console Issues or PRs related to the Halo Console label Aug 24, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2023
@JohnNiang JohnNiang requested a review from ruibaby August 24, 2023 14:25
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 42ef726 into halo-dev:main Aug 24, 2023
4 checks passed
@GodlessLiu GodlessLiu deleted the fix/#4476 branch August 25, 2023 01:59
@ruibaby ruibaby added this to the 2.9.0 milestone Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

修改附件显示模式后,希望能保存状态
4 participants