Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the search for comments by username yields empty results #4481

Merged
merged 3 commits into from Aug 25, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 25, 2023

What type of PR is this?

/kind bug
/area console
/milestone 2.9.x

What this PR does / why we need it:

Console 评论列表中,使用用户名查询时携带 kind

How to test it?

在 Console 端评论列表,选中右上角评论者,进行选择。

Which issue(s) this PR fixes:

Fixes #4465

Does this PR introduce a user-facing change?

解决评论列表根据评论者条件筛选时为空的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 25, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.9.x milestone Aug 25, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Aug 25, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and guqing August 25, 2023 03:42
@LIlGG LIlGG requested a review from ruibaby August 25, 2023 04:15
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #4481 (645baac) into main (42ef726) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4481   +/-   ##
=========================================
  Coverage     61.11%   61.11%           
  Complexity     2523     2523           
=========================================
  Files           372      372           
  Lines         12942    12942           
  Branches        929      929           
=========================================
  Hits           7909     7909           
  Misses         4582     4582           
  Partials        451      451           

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit ec0187d into halo-dev:main Aug 25, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.9.x, 2.9.0 Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console 端评论根据用户搜索为空
3 participants