Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add batch operation feature for plugins #4482

Merged
merged 6 commits into from Aug 25, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 25, 2023

What type of PR is this?

/area console
/kind feature
/milestone 2.9.x

What this PR does / why we need it:

支持对插件进行批量操作。

image

Which issue(s) this PR fixes:

Fixes #4475

Special notes for your reviewer:

测试批量对插件进行启用、停用、卸载。

Does this PR introduce a user-facing change?

Console 端的插件管理支持批量操作。

Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Aug 25, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.9.x milestone Aug 25, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from guqing August 25, 2023 04:01
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 25, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from wzrove August 25, 2023 04:01
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@138ffde). Click here to learn what that means.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4482   +/-   ##
=======================================
  Coverage        ?   60.96%           
  Complexity      ?     2558           
=======================================
  Files           ?      373           
  Lines           ?    13144           
  Branches        ?      938           
=======================================
  Hits            ?     8013           
  Misses          ?     4676           
  Partials        ?      455           

Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

按下启用、停用时,提示的内容不正确

停用提示:
image

@ruibaby
Copy link
Member Author

ruibaby commented Aug 25, 2023

按下启用、停用时,提示的内容不正确

已经在 baed1d0 中修改。

Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
测试正常

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@JohnNiang
Copy link
Member

合并之前需要解决一下以下冲突:

console/src/locales/en.yaml
console/src/locales/zh-CN.yaml
console/src/locales/zh-TW.yaml
console/src/modules/system/plugins/components/PluginListItem.vue

@f2c-ci-robot f2c-ci-robot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Aug 25, 2023
@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2023
@JohnNiang
Copy link
Member

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit f01e04f into halo-dev:main Aug 25, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.9.x, 2.9.0 Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

插件管理支持批量操作
4 participants