Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: approved filter in comment management is ineffective #4502

Merged
merged 2 commits into from Aug 30, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 28, 2023

What type of PR is this?

/kind bug
/area console
/milestone 2.9.x

What this PR does / why we need it:

解决评论管理中,根据是否已审核状态的筛选无效的问题

How to test it?

在评论列表上切换审核状态,查看是否有效。

Which issue(s) this PR fixes:

Fixes #4494

Does this PR introduce a user-facing change?

修复评论管理中审核状态筛选无效的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Aug 28, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.9.x milestone Aug 28, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #4502 (9173783) into main (a28c9a9) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4502   +/-   ##
=========================================
  Coverage     61.00%   61.00%           
  Complexity     2558     2558           
=========================================
  Files           373      373           
  Lines         13142    13142           
  Branches        937      937           
=========================================
  Hits           8017     8017           
  Misses         4670     4670           
  Partials        455      455           

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit d0f223e into halo-dev:main Aug 30, 2023
4 checks passed
@JohnNiang JohnNiang modified the milestones: 2.9.x, 2.9.0 Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

评论管理的状态筛选条件无效
4 participants