Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add restore by backup record supports #4511

Merged
merged 7 commits into from Sep 1, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 29, 2023

What type of PR is this?

/area console
/kind feature
/milestone 2.9.x

What this PR does / why we need it:

支持选择已有备份进行恢复。

image

Special notes for your reviewer:

需要测试在恢复界面通过选择已有备份进行恢复的功能是否正常。

Does this PR introduce a user-facing change?

系统恢复功能支持选择已有备份进行系统恢复。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Aug 29, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.9.x milestone Aug 29, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and LIlGG August 29, 2023 06:57
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 29, 2023
@ruibaby ruibaby changed the title feat: add restore by backup record supports WIP: feat: add restore by backup record supports Aug 29, 2023
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #4511 (f859ba8) into main (1892dce) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4511   +/-   ##
=========================================
  Coverage     61.02%   61.02%           
  Complexity     2560     2560           
=========================================
  Files           373      373           
  Lines         13149    13149           
  Branches        937      937           
=========================================
  Hits           8024     8024           
  Misses         4670     4670           
  Partials        455      455           

@ruibaby
Copy link
Member Author

ruibaby commented Aug 31, 2023

/retitle feat: add restore by backup record supports

Ready for code review

@f2c-ci-robot f2c-ci-robot bot changed the title WIP: feat: add restore by backup record supports feat: add restore by backup record supports Aug 31, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2023
@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 31, 2023
@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 31, 2023
Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 6dd77af into halo-dev:main Sep 1, 2023
4 checks passed
@JohnNiang JohnNiang removed this from the 2.9.x milestone Sep 1, 2023
@JohnNiang JohnNiang added this to the 2.9.0 milestone Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants