Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extension point for extend field items of data list #4514

Merged
merged 10 commits into from Aug 31, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 29, 2023

What type of PR is this?

/area console
/kind feature
/milestone 2.9.x

What this PR does / why we need it:

添加扩展数据列表中字段的基础能力,并为插件管理列表的字段添加扩展点以测试此扩展能力。

image

文档:https://github.com/halo-dev/halo/pull/4514/files#diff-3fa20be5b2061cc7b68fb5581f1f9ba64daac5831c6ccfdc9ff99f1b4b77a0a4

todo:

  • 场景测试
  • 文档

Which issue(s) this PR fixes:

Fixes #4497

Does this PR introduce a user-facing change?

Console 端的插件列表的显示字段支持扩展。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 29, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.9.x milestone Aug 29, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 29, 2023
Signed-off-by: Ryan Wang <i@ryanc.cc>
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #4514 (5a0a1bb) into main (ed98a16) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4514   +/-   ##
=========================================
  Coverage     61.00%   61.00%           
  Complexity     2558     2558           
=========================================
  Files           373      373           
  Lines         13142    13142           
  Branches        937      937           
=========================================
  Hits           8017     8017           
  Misses         4670     4670           
  Partials        455      455           

@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2023
@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2023
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Copy link
Member Author

ruibaby commented Aug 31, 2023

/retitle feat: add extension point for extend field items of data list

Ready for code review

@f2c-ci-robot f2c-ci-robot bot changed the title WIP: feat: add extension point for extend field items of data list feat: add extension point for extend field items of data list Aug 31, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit aa95bbb into halo-dev:main Aug 31, 2023
4 checks passed
@ruibaby ruibaby deleted the feat/entity-field-extend branch August 31, 2023 03:34
@ruibaby ruibaby modified the milestones: 2.9.x, 2.9.0 Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望插件管理列表的展示字段支持扩展
3 participants