Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make theme list item operations extendable #4523

Merged
merged 3 commits into from Aug 31, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 30, 2023

What type of PR is this?

/area console
/kind feature
/milestone 2.9.x

What this PR does / why we need it:

主题管理列表项的操作按钮支持被插件扩展。

image

Which issue(s) this PR fixes:

Fixes #4522

Special notes for your reviewer:

测试已有的操作按钮功能正常即可。

Does this PR introduce a user-facing change?

Console 主题管理列表项的操作按钮支持被插件扩展。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 30, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.9.x milestone Aug 30, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang August 30, 2023 10:34
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #4523 (b699c25) into main (329b389) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4523   +/-   ##
=========================================
  Coverage     61.00%   61.00%           
  Complexity     2558     2558           
=========================================
  Files           373      373           
  Lines         13142    13142           
  Branches        937      937           
=========================================
  Hits           8017     8017           
  Misses         4670     4670           
  Partials        455      455           

@ruibaby
Copy link
Member Author

ruibaby commented Aug 31, 2023

/retitle feat: make theme list item operations extendable

Ready for review

@f2c-ci-robot f2c-ci-robot bot changed the title WIP: feat: make theme list item operations extendable feat: make theme list item operations extendable Aug 31, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2023
@ruibaby ruibaby requested a review from LIlGG August 31, 2023 04:52
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 8eaedd6 into halo-dev:main Aug 31, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.9.x, 2.9.0 Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

主题管理列表项的操作按钮需要支持扩展
3 participants