Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: operation items render issue in theme list #4563

Merged
merged 1 commit into from Sep 7, 2023
Merged

fix: operation items render issue in theme list #4563

merged 1 commit into from Sep 7, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 6, 2023 •
edited

What type of PR is this?

/area console
/kind bug

What this PR does / why we need it:

修复主题管理列表的更多操作项在某些情况下无法打开的问题。

image

Which issue(s) this PR fixes:

Fixes #4559

Special notes for your reviewer:

测试方式：

  1. 安装若干主题，测试每一项主题的更多操作按钮是否可以正常打开。
  2. 删除某一个主题，测试每一项主题的更多操作按钮是否可以正常打开。

Does this PR introduce a user-facing change?

修复 Console 端主题管理列表的更多操作项在某些情况下无法打开的问题。

@ruibaby
fix: operation items render issue in theme list
ffc1a67 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Sep 6, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from Aanko September 6, 2023 10:03
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 6, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG September 6, 2023 10:03
@ruibaby
Copy link
Member Author

ruibaby commented Sep 6, 2023

/cherrypick release-2.9

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby added this to the 2.10.x milestone Sep 6, 2023
guqing
guqing reviewed Sep 7, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

works fine👍

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2023
JohnNiang
JohnNiang approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit eea575c into halo-dev:main Sep 7, 2023
4 checks passed
@halo-dev-bot halo-dev-bot mentioned this pull request Sep 7, 2023
Merged
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #4569

In response to this:

/cherrypick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Sep 7, 2023
@halo-dev-bot
[release-2.9] fix: operation items render issue in theme list (#4569)
bd4c9c6 
This is an automated cherry-pick of #4563

/assign ruibaby

```release-note
修复 Console 端主题管理列表的更多操作项在某些情况下无法打开的问题。
```
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@Aanko Aanko Awaiting requested review from Aanko

@LIlGG LIlGG Awaiting requested review from LIlGG

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

主题管理中列表项的更多操作按钮在某些情况下无法展开
4 participants
@ruibaby @halo-dev-bot @JohnNiang @guqing