Support for personal access token mechanism #4598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
f2c-ci-robot
bot
added
kind/api-change
Codecov Report
@@ Coverage Diff @@
## main #4598 +/- ##
============================================
- Coverage 61.11% 61.01% -0.11%
- Complexity 2570 2611 +41
============================================
Files 374 378 +4
Lines 13171 13550 +379
Branches 938 958 +20
============================================
+ Hits 8049 8267 +218
- Misses 4669 4817 +148
- Partials 453 466 +13
|
|
/milestone 2.10.x |
JohnNiang
changed the title
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
|
/hold TODO:
|
f2c-ci-robot
bot
added
the
do-not-merge/hold
JohnNiang
force-pushed
the
feat/personal-access-token
branch
from
287b21d
to
d4a8080
Compare
JohnNiang
force-pushed
the
feat/personal-access-token
branch
from
9c568dd
to
1e1285e
Compare
JohnNiang
added
the
tide/merge-method-merge
|
/unhold |
f2c-ci-robot
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
#### What type of PR is this? /kind improvement /kind api-change /area core #### What this PR does / why we need it: This PR refines route paths created from <#4598>. Because the user scope is not necessary here. #### Special notes for your reviewer: Try to manage your PATs. #### Does this PR introduce a user-facing change? ```release-note None ```
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
#### What type of PR is this? /kind bug /area core #### What this PR does / why we need it: After PAT mechanism implemented by <#4598>, if we use the same PAT to request endpoints concurrently, we may encounter an error like the screenshot below: <img width="1920" alt="image" src="https://github.com/halo-dev/halo/assets/16865714/30899a0c-ad98-44a1-ae7d-0eda603945f0"> This PR fixes the problem introduced by <#4598>. We update the lastUsed timestamp of PAT at least one minute apart and with retry. #### Does this PR introduce a user-facing change? ```release-note None ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
/area core
What this PR does / why we need it:
Support for personal access token mechanism.
Which issue(s) this PR fixes:
Fixes #1309
Special notes for your reviewer:
Does this PR introduce a user-facing change?