Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refine notifications-related ui #4638

Merged
merged 17 commits into from Sep 28, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 20, 2023

What type of PR is this?

/area console
/kind feature
/milestone 2.10.x

What this PR does / why we need it:

完善通知功能相关的 UI 功能。

配置:

image

仪表盘消息组件:

image

独立的消息页面:

image

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None 

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/console Issues or PRs related to the Halo Console release-note-none Denotes a PR that doesn't merit a release note. labels Sep 20, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 20, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #4638 (2d606a6) into main (a5a6978) will not change coverage.
Report is 9 commits behind head on main.
The diff coverage is n/a.

❗ Current head 2d606a6 differs from pull request most recent head 6907bad. Consider uploading reports for the commit 6907bad to get more accurate results

@@            Coverage Diff            @@
##               main    #4638   +/-   ##
=========================================
  Coverage     61.02%   61.02%           
  Complexity     2610     2610           
=========================================
  Files           378      378           
  Lines         13541    13541           
  Branches        958      958           
=========================================
  Hits           8264     8264           
  Misses         4812     4812           
  Partials        465      465           

Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2023
@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2023
JohnNiang and others added 4 commits September 25, 2023 21:38
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Copy link
Member Author

ruibaby commented Sep 26, 2023

/retitle feat: refine notifications-related ui

@f2c-ci-robot f2c-ci-robot bot changed the title WIP: feat: refine notifications-related ui feat: refine notifications-related ui Sep 26, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2023
@JohnNiang JohnNiang removed this from the 2.10.x milestone Sep 27, 2023
@JohnNiang JohnNiang added this to the 2.10.0 milestone Sep 27, 2023
Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 3edf863 into halo-dev:main Sep 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants