Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add app store plugin as preset-plugin #4670

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 28, 2023

What type of PR is this?

/area core
/kind improvement
/milestone 2.10.x

What this PR does / why we need it:

添加 https://github.com/halo-dev/plugin-app-store 作为预设插件。

Does this PR introduce a user-facing change?

添加应用市场预设插件

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 28, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 28, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 28, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #4670 (4083506) into main (86db26a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4670   +/-   ##
=========================================
  Coverage     61.05%   61.05%           
  Complexity     2610     2610           
=========================================
  Files           379      379           
  Lines         13606    13606           
  Branches        960      960           
=========================================
  Hits           8307     8307           
  Misses         4832     4832           
  Partials        467      467           

@LIlGG
Copy link
Member

LIlGG commented Sep 28, 2023

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 45787e1 into halo-dev:main Sep 28, 2023
4 checks passed
@ruibaby ruibaby deleted the chore/add-plugin-app-store-as-preset branch September 28, 2023 16:16
@JohnNiang JohnNiang modified the milestones: 2.10.x, 2.10.0 Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants