Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect truncation of CSS resource reads #4678

Merged
merged 1 commit into from Oct 7, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Oct 7, 2023

What type of PR is this?

/kind bug
/area core
/milestone 2.10.x

What this PR does / why we need it:

修复插件 css bundle 内容被错误拆分导致无法加载的问题

Which issue(s) this PR fixes:

Fixes #4677

Does this PR introduce a user-facing change?

修复插件 css bundle 内容被错误拆分导致无法加载的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 7, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Oct 7, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 7, 2023
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #4678 (d269fa5) into main (3edf863) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #4678      +/-   ##
============================================
- Coverage     61.75%   61.73%   -0.03%     
  Complexity     2781     2781              
============================================
  Files           402      402              
  Lines         14579    14584       +5     
  Branches       1011     1011              
============================================
  Hits           9003     9003              
- Misses         5087     5092       +5     
  Partials        489      489              
Files Coverage Δ
...core/extension/service/impl/PluginServiceImpl.java 63.47% <0.00%> (-2.89%) ⬇️

Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LIlGG, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit d443c3e into halo-dev:main Oct 7, 2023
4 checks passed
@guqing guqing deleted the bugfix/css-uglify branch October 7, 2023 10:45
@JohnNiang JohnNiang modified the milestones: 2.10.x, 2.10.0 Oct 8, 2023
@ruibaby ruibaby modified the milestones: 2.10.0, 2.10.x Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

console 端插件的 css 有概率不生效
4 participants