Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loading state for switch component #4688

Merged
merged 2 commits into from Oct 8, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 8, 2023

What type of PR is this?

/area console
/kind feature
/milestone 2.10.x

What this PR does / why we need it:

VSwitch 组件支持传入 loading 属性以显示加载状态。

此外,此 PR 为插件启动/停止的开关适配了这个特性用于测试。

image

Which issue(s) this PR fixes:

Fixes #4687

Special notes for your reviewer:

测试插件启动/停止时是否显示加载状态

Does this PR introduce a user-facing change?

Console 端的 VSwitch 组件支持传入 loading 属性以显示加载状态。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Oct 8, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Oct 8, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 8, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen October 8, 2023 04:33
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #4688 (713ebc5) into main (d443c3e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4688   +/-   ##
=========================================
  Coverage     61.73%   61.73%           
  Complexity     2781     2781           
=========================================
  Files           402      402           
  Lines         14584    14584           
  Branches       1011     1011           
=========================================
  Hits           9003     9003           
  Misses         5092     5092           
  Partials        489      489           

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit df22b4b into halo-dev:main Oct 8, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望能够让 Switch 组件支持加载状态
3 participants