Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the display error in the comments page status filter text #4743

Merged
merged 2 commits into from Oct 19, 2023
Merged

Fix the display error in the comments page status filter text #4743

merged 2 commits into from Oct 19, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 17, 2023 •
edited by ruibaby

What type of PR is this?

/kind bug
/area console

What this PR does / why we need it:

fix-status-filter-2

Which issue(s) this PR fixes:

Fixes #4731

Special notes for your reviewer:

Does this PR introduce a user-facing change?

修复 Console 端评论状态筛选无法显示筛选结果的问题。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited

Codecov Report

Merging #4743 (ba16b92) into main (ff7af9f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4743   +/-   ##
=========================================
  Coverage     61.58%   61.58%           
  Complexity     2797     2797           
=========================================
  Files           403      403           
  Lines         14725    14725           
  Branches       1023     1023           
=========================================
  Hits           9068     9068           
  Misses         5165     5165           
  Partials        492      492

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 19, 2023
@ruibaby ruibaby added release-note-none Denotes a PR that doesn't merit a release note. area/console Issues or PRs related to the Halo Console and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 19, 2023
@ruibaby ruibaby added this to the 2.11.x milestone Oct 19, 2023
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 19, 2023
ruibaby
ruibaby reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@ruibaby
Copy link
Member

ruibaby commented Oct 19, 2023

/cherrypick release-2.10

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.10 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

guqing
guqing reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

JohnNiang
JohnNiang approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@JohnNiang JohnNiang changed the title fix: Fixed the display error in the comments page status filter text Fix the display error in the comments page status filter text Oct 19, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 4af8271 into halo-dev:main Oct 19, 2023
4 checks passed
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #4754

In response to this:

/cherrypick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@halo-dev-bot halo-dev-bot mentioned this pull request Oct 19, 2023
Merged
f2c-ci-robot bot pushed a commit that referenced this pull request Oct 19, 2023
@halo-dev-bot
[release-2.10] Fix the display error in the comments page status filt…
3f3e5ee 
…er text (#4754)

This is an automated cherry-pick of #4743

/assign ruibaby

```release-note
修复 Console 端评论状态筛选无法显示筛选结果的问题
```
@JohnNiang JohnNiang modified the milestones: 2.11.x, 2.11.0 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LIlGG LIlGG Awaiting requested review from LIlGG

Assignees

@ruibaby ruibaby

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

评论页面过滤状态时，文本显示错误
5 participants
@ruibaby @halo-dev-bot @JohnNiang @guqing @zjy2024