New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change the ref parameter type in the list method of comment finder api to map #4773
Conversation
…when the method was called
Codecov Report
@@ Coverage Diff @@
## main #4773 +/- ##
============================================
- Coverage 61.50% 61.47% -0.03%
Complexity 2798 2798
============================================
Files 403 403
Lines 14772 14779 +7
Branches 1029 1029
============================================
Hits 9086 9086
- Misses 5193 5200 +7
Partials 493 493
|
Hi @halo-dev/sig-halo ,这里有办法方便构建 Ref 对象来解决这个问题么?我看 SpEL 是可以直接调用类方法的,请参考:https://docs.spring.io/spring-framework/reference/core/expressions/language-ref/constructors.html。 |
还是直接map吧,对象确实不方便,需要指定全限定名来 new,而 Ref 没有全参数构造方法 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
当前修改符合主题文档描述:https://docs.halo.run/developer-guide/theme/finder-apis/comment#%E6%8F%8F%E8%BF%B0-1。
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-2.10 |
@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ruibaby: new pull request created: #4779 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
这个修改是否需要修改文档? |
不需要,这个改动恰好符合文档描述 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
在主题使用如下FinderAPI时
将产生如下错误
因为方法定义为
所以修改方法参数
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?