Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of creating PAT with hidden roles #4800

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Oct 31, 2023

What type of PR is this?

/kind bug
/area core
/milestone 2.11.x

What this PR does / why we need it:

Fix the problem that we will encounter "insufficient roles" error while creating PAT with hidden roles.

Which issue(s) this PR fixes:

Fixes #4783

Does this PR introduce a user-facing change?

修复因部分角色导致无法正常创建个人令牌的问题。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 31, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.x milestone Oct 31, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 31, 2023
@JohnNiang
Copy link
Member Author

/cherrypick release-2.10

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.10 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #4800 (b7c9709) into main (f2d7376) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #4800   +/-   ##
=========================================
  Coverage     61.46%   61.46%           
  Complexity     2798     2798           
=========================================
  Files           403      403           
  Lines         14783    14783           
  Branches       1031     1031           
=========================================
  Hits           9086     9086           
  Misses         5202     5202           
  Partials        495      495           
Files Coverage Δ
...app/core/extension/service/DefaultRoleService.java 51.16% <0.00%> (ø)

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
Copy link

f2c-ci-robot bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit dcf0996 into halo-dev:main Nov 1, 2023
4 checks passed
@JohnNiang
Copy link
Member Author

/cherrypick release-2.10

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #4808

In response to this:

/cherrypick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Nov 1, 2023
This is an automated cherry-pick of #4800

/assign JohnNiang

```release-note
修复因部分角色导致无法正常创建个人令牌的问题
```
@JohnNiang JohnNiang modified the milestones: 2.11.x, 2.11.0 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

非管理员账号创建 PAT 时,如果选择了权限将无法创建 PAT
4 participants