New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the problem of creating PAT with hidden roles #4800
Fix the problem of creating PAT with hidden roles #4800
Conversation
/cherrypick release-2.10 |
@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #4800 +/- ##
=========================================
Coverage 61.46% 61.46%
Complexity 2798 2798
=========================================
Files 403 403
Lines 14783 14783
Branches 1031 1031
=========================================
Hits 9086 9086
Misses 5202 5202
Partials 495 495
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cherrypick release-2.10 |
@JohnNiang: new pull request created: #4808 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #4800 /assign JohnNiang ```release-note 修复因部分角色导致无法正常创建个人令牌的问题 ```
What type of PR is this?
/kind bug
/area core
/milestone 2.11.x
What this PR does / why we need it:
Fix the problem that we will encounter "insufficient roles" error while creating PAT with hidden roles.
Which issue(s) this PR fixes:
Fixes #4783
Does this PR introduce a user-facing change?