Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generator meta into head #4821

Merged
merged 1 commit into from Nov 6, 2023

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Nov 5, 2023

What type of PR is this?

/kind feature
/area core
/milestone 2.11.x

What this PR does / why we need it:

Please see https://html.spec.whatwg.org/multipage/semantics.html#meta-generator for more.

This PR add the generator meta into head, so that we can know what sites are using Halo.

http localhost:8090/ | grep generator

<meta name="generator" content="Halo 2.11.0-SNAPSHOT"/>

If someone want to disable the generator meta, they can configure the property halo.theme.generator-meta-disabled to true.

Does this PR introduce a user-facing change?

添加 Generator 元数据标识

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 5, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.x milestone Nov 5, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Nov 5, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG November 5, 2023 07:51
@ruibaby
Copy link
Member

ruibaby commented Nov 5, 2023

建议在配置文件提供一个开关。

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #4821 (5ee0240) into main (caa4d44) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #4821      +/-   ##
============================================
+ Coverage     61.49%   61.53%   +0.03%     
- Complexity     2806     2811       +5     
============================================
  Files           405      406       +1     
  Lines         14807    14820      +13     
  Branches       1030     1030              
============================================
+ Hits           9106     9119      +13     
  Misses         5205     5205              
  Partials        496      496              
Files Coverage Δ
...run/halo/app/infra/properties/ThemeProperties.java 71.42% <100.00%> (+4.76%) ⬆️
...in/java/run/halo/app/theme/ThemeConfiguration.java 50.00% <100.00%> (+1.61%) ⬆️
...halo/app/theme/dialect/GeneratorMetaProcessor.java 100.00% <100.00%> (ø)

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

图片

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2023
@JohnNiang JohnNiang added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2023
Copy link

f2c-ci-robot bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 4ea2014 into halo-dev:main Nov 6, 2023
4 checks passed
Copy link

f2c-ci-robot bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnNiang JohnNiang deleted the feat/generator-meta branch November 6, 2023 02:58
@JohnNiang JohnNiang modified the milestones: 2.11.x, 2.11.0 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants