New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generator meta into head #4821
Conversation
建议在配置文件提供一个开关。 |
2210efe
to
5ee0240
Compare
Codecov Report
@@ Coverage Diff @@
## main #4821 +/- ##
============================================
+ Coverage 61.49% 61.53% +0.03%
- Complexity 2806 2811 +5
============================================
Files 405 406 +1
Lines 14807 14820 +13
Branches 1030 1030
============================================
+ Hits 9106 9119 +13
Misses 5205 5205
Partials 496 496
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area core
/milestone 2.11.x
What this PR does / why we need it:
Please see https://html.spec.whatwg.org/multipage/semantics.html#meta-generator for more.
This PR add the generator meta into head, so that we can know what sites are using Halo.
If someone want to disable the generator meta, they can configure the property
halo.theme.generator-meta-disabled
totrue
.Does this PR introduce a user-facing change?