Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem where some Windows developers are unable to build project #4844

Merged

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core

What this PR does / why we need it:

Currently, some Windows developers using GBK as character encoding are unable to build project, please see #4771 for more.

Because the source code are using UTF-8 character encoding, the javadoc, compileJava, compileTestJava and delombok tasks will use the default character encoding GBK to handle the sources, which prevents the :api:javadoc task from running properly.

At the same time, we thank to @DaiYuANg for his first proposed solution in #4517.

Which issue(s) this PR fixes:

Fixes #4771

Special notes for your reviewer:

Validate the result by executing command ./gradlew clean build -x check on Windows environment.

Does this PR introduce a user-facing change?

修复在部分 Windows 开发者无法正常构建 Halo 的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/core Issues or PRs related to the Halo Core labels Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #4844 (ae9115f) into main (4ea2014) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4844   +/-   ##
=========================================
  Coverage     61.53%   61.53%           
  Complexity     2811     2811           
=========================================
  Files           406      406           
  Lines         14820    14820           
  Branches       1030     1030           
=========================================
  Hits           9119     9119           
  Misses         5205     5205           
  Partials        496      496           

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

图片

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2023
Copy link

f2c-ci-robot bot commented Nov 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit ee52adf into halo-dev:main Nov 12, 2023
4 checks passed
@JohnNiang JohnNiang deleted the bug/javadoc-task-failed-on-windows branch November 12, 2023 13:24
@JohnNiang JohnNiang added this to the 2.11.x milestone Nov 12, 2023
@ruibaby ruibaby modified the milestones: 2.11.x, 2.11.0 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execution failed for task ':api:javadoc'(win10)
3 participants