Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add devices mock preview for post and single page #4846

Merged
merged 1 commit into from Nov 13, 2023

Conversation

Thematrixofink
Copy link
Contributor

@Thematrixofink Thematrixofink commented Nov 11, 2023

What type of PR is this?

/kind feature
/area console

What this PR does / why we need it:

为文章以及页面预览增加终端切换功能,类似于预览主题的终端切换

Which issue(s) this PR fixes:

Fixes #4789

Special notes for your reviewer:

测试方式:
本地运行halo,预览文章和页面,切换不同终端,各个界面正常显示且功能正常。

Does this PR introduce a user-facing change?

文章预览支持模拟不同设备尺寸。

Signed-off-by: zhangru <2495760174@qq.com>
@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. area/console Issues or PRs related to the Halo Console labels Nov 11, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wzrove November 11, 2023 08:39
@CLAassistant
Copy link

CLAassistant commented Nov 11, 2023

CLA assistant check
All committers have signed the CLA.

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 11, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

图片

感谢 @Thematrixofink 参与贡献。

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2023
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #4846 (d6922cb) into main (4ea2014) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4846   +/-   ##
=========================================
  Coverage     61.53%   61.53%           
  Complexity     2811     2811           
=========================================
  Files           406      406           
  Lines         14820    14820           
  Branches       1030     1030           
=========================================
  Hits           9119     9119           
  Misses         5205     5205           
  Partials        496      496           

@ruibaby
Copy link
Member

ruibaby commented Nov 11, 2023

/milestone 2.11.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.x milestone Nov 11, 2023
@ruibaby ruibaby changed the title 为文章及页面预览增加终端切换功能 feat: add devices mock preview for post and single page Nov 11, 2023
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 11, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution!

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
Copy link

f2c-ci-robot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 4a6ce88 into halo-dev:main Nov 13, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.11.x, 2.11.0 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文章及页面预览增加终端切换功能
4 participants