Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support user email verification mechanism #4878

Merged
merged 13 commits into from Nov 27, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Nov 18, 2023

What type of PR is this?

/kind feature
/area core
/milestone 2.11.x

What this PR does / why we need it:

新增用户邮箱验证机制

Which issue(s) this PR fixes:

Fixes #4656

Special notes for your reviewer:

Does this PR introduce a user-facing change?

新增用户邮箱验证机制

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 18, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.x milestone Nov 18, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Nov 18, 2023
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 94 lines in your changes are missing coverage. Please review.

Comparison is base (82a6ba6) 56.81% compared to head (4196911) 56.76%.

Files Patch % Lines
...ion/service/impl/EmailVerificationServiceImpl.java 36.75% 74 Missing ⚠️
...halo/app/core/extension/endpoint/UserEndpoint.java 79.41% 13 Missing and 1 partial ⚠️
...o/app/infra/exception/EmailVerificationFailed.java 33.33% 4 Missing ⚠️
...rc/main/java/run/halo/app/core/extension/User.java 0.00% 1 Missing ⚠️
.../main/java/run/halo/app/infra/ValidationUtils.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4878      +/-   ##
============================================
- Coverage     56.81%   56.76%   -0.05%     
- Complexity     2972     2990      +18     
============================================
  Files           515      517       +2     
  Lines         16939    17131     +192     
  Branches       1274     1283       +9     
============================================
+ Hits           9624     9725     +101     
- Misses         6773     6862      +89     
- Partials        542      544       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing force-pushed the feature/4656 branch 6 times, most recently from 94a8199 to 330ac80 Compare November 21, 2023 08:37
Signed-off-by: guqing <1484563614@qq.com>
@guqing guqing changed the title feat: support user email verification mechanism [WIP] feat: support user email verification mechanism Nov 22, 2023
@guqing guqing marked this pull request as ready for review November 22, 2023 02:30
@guqing
Copy link
Member Author

guqing commented Nov 22, 2023

/cc @ruibaby 需要在前端进行适配

@ruibaby
Copy link
Member

ruibaby commented Nov 23, 2023

/cc @ruibaby 需要在前端进行适配

Working on it

ruibaby and others added 8 commits November 23, 2023 11:57
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Copy link
Member

ruibaby commented Nov 23, 2023

/retitle feat: support user email verification mechanism

Ready for review.

关于 Console 部分的 i18n 我将在后续的 PR 完善,因为分离个人中心之后需要重新整理一下 i18n 文件的结构。

@f2c-ci-robot f2c-ci-robot bot changed the title [WIP] feat: support user email verification mechanism feat: support user email verification mechanism Nov 23, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2023
@JohnNiang JohnNiang modified the milestones: 2.11.x, 2.11.0 Nov 24, 2023
@guqing
Copy link
Member Author

guqing commented Nov 24, 2023

/ping @halo-dev/sig-halo

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
Copy link

f2c-ci-robot bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 96d4897 into halo-dev:main Nov 27, 2023
4 checks passed
@guqing guqing deleted the feature/4656 branch November 27, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望支持用户注册验证
3 participants