Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent private posts from being indexed when rebuilding index. #4882

Merged
merged 1 commit into from Nov 21, 2023

Conversation

AirboZH
Copy link
Member

@AirboZH AirboZH commented Nov 21, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

在加入索引前判断文章的可见性。只将PUBLIC文章加入索引,修复手动刷新搜索索引会将私有文章加入索引的问题

Which issue(s) this PR fixes:

Fix #4879

Special notes for your reviewer:

null

Does this PR introduce a user-facing change?

修复手动刷新搜索索引会将私有文章加入索引的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Nov 21, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and ruibaby November 21, 2023 01:25
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fbc9045) 56.70% compared to head (acecf5c) 56.69%.

Files Patch % Lines
...java/run/halo/app/core/extension/content/Post.java 0.00% 1 Missing ⚠️
...n/java/run/halo/app/search/IndicesServiceImpl.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4882      +/-   ##
============================================
- Coverage     56.70%   56.69%   -0.01%     
  Complexity     2969     2969              
============================================
  Files           514      514              
  Lines         16905    16907       +2     
  Branches       1273     1273              
============================================
  Hits           9586     9586              
- Misses         6782     6784       +2     
  Partials        537      537              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

/approve

Copy link

f2c-ci-robot bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
@JohnNiang JohnNiang changed the title fix: Prevent private posts from being indexed when rebuilding index. Prevent private posts from being indexed when rebuilding index. Nov 21, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit aa9f84e into halo-dev:main Nov 21, 2023
4 checks passed
@JohnNiang
Copy link
Member

/milestone 2.11.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.x milestone Nov 21, 2023
@JohnNiang JohnNiang modified the milestones: 2.11.x, 2.11.0 Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

未登录状态下仍然可以通过搜索引擎搜索到私有文章信息
3 participants