Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move @halo-sigs/richtext-editor to this repository #4934

Merged
merged 2 commits into from Nov 29, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 28, 2023

What type of PR is this?

/area console
/area editor
/kind improvement
/milestone 2.11.x

What this PR does / why we need it:

https://github.com/halo-sigs/richtext-editor 移动到此仓库进行管理。

Which issue(s) this PR fixes:

Fixes #4932

Special notes for your reviewer:

测试方式:

  1. 移动到 console/packages/editor 目录,执行 pnpm dev,测试能否正常使用开发环境。
  2. 在 console 目录执行 pnpm build:packages,然后启动 Console 的 dev server,测试在 Console 中能否正常使用编辑器。

Does this PR introduce a user-facing change?

将 [halo-sigs/richtext-editor](https://github.com/halo-sigs/richtext-editor) 移动到此仓库进行管理。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 28, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.x milestone Nov 28, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Nov 28, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99edbdd) 56.76% compared to head (5649a42) 56.76%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4934   +/-   ##
=========================================
  Coverage     56.76%   56.76%           
  Complexity     2990     2990           
=========================================
  Files           517      517           
  Lines         17131    17131           
  Branches       1283     1283           
=========================================
  Hits           9725     9725           
  Misses         6862     6862           
  Partials        544      544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

不要忘记将仓库 https://github.com/halo-sigs/richtext-editor 归档,并链接到新的地址。

Copy link

f2c-ci-robot bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@JohnNiang JohnNiang merged commit e054e9b into halo-dev:main Nov 29, 2023
4 checks passed
ruibaby added a commit to JohnNiang/halo that referenced this pull request Nov 29, 2023
)

* chore: move @halo-sigs/richtext-editor to this repository

Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby ruibaby deleted the chore/add-editor branch November 29, 2023 14:20
@ruibaby ruibaby modified the milestones: 2.11.x, 2.11.0 Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console area/editor Issues or PRs related to the Editor kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

将 halo-sigs/richtext-editor 移动到 console/packages 进行管理
3 participants