Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support reset passwords based on email address #4941

Merged
merged 10 commits into from Dec 1, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Nov 29, 2023

What type of PR is this?

/kind feature
/area core
/area console
/milestone 2.11.x

What this PR does / why we need it:

新增使用邮箱地址找回密码功能

Which issue(s) this PR fixes:

Fixes #4940

Does this PR introduce a user-facing change?

新增使用邮箱地址找回密码功能

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 29, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.x milestone Nov 29, 2023
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core area/console Issues or PRs related to the Halo Console labels Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (5e76da0) 56.08% compared to head (564fe0b) 55.95%.

Files Patch % Lines
...service/impl/EmailPasswordRecoveryServiceImpl.java 39.17% 59 Missing ⚠️
...un/halo/app/theme/endpoint/PublicUserEndpoint.java 44.64% 31 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4941      +/-   ##
============================================
- Coverage     56.08%   55.95%   -0.13%     
- Complexity     3032     3035       +3     
============================================
  Files           524      525       +1     
  Lines         17663    17816     +153     
  Branches       1319     1329      +10     
============================================
+ Hits           9906     9969      +63     
- Misses         7209     7299      +90     
  Partials        548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby
Copy link
Member

ruibaby commented Nov 30, 2023

/retitle feat: support reset passwords based on email address

Ready for review, cc @halo-dev/sig-halo

@f2c-ci-robot f2c-ci-robot bot changed the title [WIP] feat: support reset passwords based on email address feat: support reset passwords based on email address Nov 30, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit abd0497 into halo-dev:main Dec 1, 2023
4 checks passed
@guqing guqing deleted the feature/retrieve-password branch December 1, 2023 03:19
@ruibaby ruibaby modified the milestones: 2.11.x, 2.11.0 Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

希望支持找回密码功能
2 participants