Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add supports for hide the sidebar of editor #4942

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 29, 2023

What type of PR is this?

/area console
/area editor
/kind feature
/milestone 2.11.0

What this PR does / why we need it:

支持隐藏/显示默认编辑器的侧边栏。

图片 图片

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

测试截图中隐藏/显示侧边栏的按钮是否正常工作即可。

Does this PR introduce a user-facing change?

支持隐藏/显示默认编辑器的侧边栏。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Nov 29, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.0 milestone Nov 29, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG November 29, 2023 10:13
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Nov 29, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen November 29, 2023 10:13
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2b096c) 56.10% compared to head (f53372f) 56.10%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4942   +/-   ##
=========================================
  Coverage     56.10%   56.10%           
  Complexity     3031     3031           
=========================================
  Files           524      524           
  Lines         17652    17652           
  Branches       1315     1315           
=========================================
  Hits           9903     9903           
  Misses         7201     7201           
  Partials        548      548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 7a84f55 into halo-dev:main Nov 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console area/editor Issues or PRs related to the Editor kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants