Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refine ui permissions of actuator page #4945

Merged
merged 1 commit into from Nov 30, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 29, 2023

What type of PR is this?

/area console
/kind improvement
/milestone 2.11.x

What this PR does / why we need it:

完善系统概览页面的 UI 权限控制。

Does this PR introduce a user-facing change?

完善系统概览页面的 UI 权限控制。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Nov 29, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.x milestone Nov 29, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c835725) 56.76% compared to head (75c4b4a) 56.76%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4945   +/-   ##
=========================================
  Coverage     56.76%   56.76%           
  Complexity     2990     2990           
=========================================
  Files           517      517           
  Lines         17131    17131           
  Branches       1283     1283           
=========================================
  Hits           9725     9725           
  Misses         6862     6862           
  Partials        544      544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit f5dcb5d into halo-dev:main Nov 30, 2023
4 checks passed
@ruibaby ruibaby deleted the feat/refine-actuator-permission branch November 30, 2023 03:00
@ruibaby ruibaby modified the milestones: 2.11.x, 2.10.x Nov 30, 2023
@JohnNiang JohnNiang modified the milestones: 2.10.x, 2.11.0 Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants