Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disallow tooltip for editor provider selector component #5070

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 19, 2023

What type of PR is this?

/area console
/kind improvement
/milestone 2.12.x

What this PR does / why we need it:

当编辑器切换组件中有不可用编辑器时,添加提示。

图片

Which issue(s) this PR fixes:

Fixes #5059

Special notes for your reviewer:

测试方式:

  1. 安装若干不同类型的编辑器,并创建文章。
  2. 修改文章时尝试选择不同类型的编辑器,观察是否有提示。

Does this PR introduce a user-facing change?

当编辑器切换组件中有不可用编辑器时,添加提示。

@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 19, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Dec 19, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b405fa) 55.94% compared to head (ee7f861) 55.91%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5070      +/-   ##
============================================
- Coverage     55.94%   55.91%   -0.03%     
+ Complexity     3034     3032       -2     
============================================
  Files           525      524       -1     
  Lines         17816    17826      +10     
  Branches       1329     1329              
============================================
+ Hits           9967     9968       +1     
- Misses         7300     7309       +9     
  Partials        549      549              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 2402013 into halo-dev:main Dec 21, 2023
4 checks passed
@JohnNiang JohnNiang modified the milestones: 2.12.x, 2.12.0 Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在文章编辑页面的编辑器切换器添加不可用提示
3 participants