Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: export necessary extensions externally #5104

Merged
merged 2 commits into from Dec 24, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Dec 22, 2023

What type of PR is this?

/kind improvement
/area editor
/milestone 2.12.x

What this PR does / why we need it:

导出一些必要的默认编辑器扩展及工具类,例如 Paragraph

Which issue(s) this PR fixes:

Fixes #5103

Does this PR introduce a user-facing change?

导出必要的默认编辑器扩展及工具类

Copy link

f2c-ci-robot bot commented Dec 22, 2023

@LIlGG: The provided milestone is not valid for this repository. Milestones in this repository: [1.6.x, 2.11.3, 2.11.x, 2.12.x, Backlog]

Use /milestone clear to clear the milestone.

In response to this:

What type of PR is this?

/kind improvement
/area editor
/milestone

What this PR does / why we need it:

导出一些必要的默认编辑器扩展及工具类,例如 Paragraph

Which issue(s) this PR fixes:

Fixes #5103

Does this PR introduce a user-facing change?

导出必要的默认编辑器扩展及工具类

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Dec 22, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Dec 22, 2023
@LIlGG
Copy link
Member Author

LIlGG commented Dec 22, 2023

/milestone 2.12.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cdd5cb4) 55.91% compared to head (223f1b2) 55.91%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5104   +/-   ##
=========================================
  Coverage     55.91%   55.91%           
  Complexity     3032     3032           
=========================================
  Files           524      524           
  Lines         17826    17826           
  Branches       1329     1329           
=========================================
  Hits           9968     9968           
  Misses         7309     7309           
  Partials        549      549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Dec 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit a1fe8c3 into halo-dev:main Dec 24, 2023
4 checks passed
@JohnNiang JohnNiang modified the milestones: 2.12.x, 2.12.0 Jan 7, 2024
@LIlGG LIlGG deleted the pref/extension-export branch January 31, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

优化默认编辑器扩展导出
3 participants